kobotoolbox / kpi / 14471343458

81%

master: 76%

push

github

fix(attachments): display attachment dropdown additionally to media in single submission modal (#5672)

### 📣 Summary
<!-- Delete this section if changes are internal only. -->
<!-- One sentence summary for the public changelog, worded for
non-technical seasoned Kobo users. -->

Fixes bug where attachment dropdown did not display beside their
respective attachments.

### 💭 Notes
<!-- Delete this section if empty. -->
<!-- Anything else useful that's not said above,worded for
reviewers, testers, and future git archaeologist collegues. Examples:
- screenshots, copy-pasted logs, etc.
- what was tried but didn't work,
- conscious short-term vs long-term tradeoffs,
- proactively answer likely questions,
-->

Went back to the "old" method to display different media types. Didn't
have issues with this in the past so seemed logical.

### 👀 Preview steps
<!-- Delete this section if behavior can't change. -->
<!-- If behavior changes or merely may change, add a preview of a
minimal happy path. -->

Bug template:
1. Enable the `removingAttachmentsEnabled` feature flag
2. Have a form with media questions and submissions
3. Open a single submission modal
4. 🔴 [on main] notice that the attachment dropdown does **not** display
next to media
5. 🟢 [on PR] notice that attachment dropdown does display next to media

6134 of 9743 branches covered (62.96%)

23457 of 28971 relevant lines covered (80.97%)

1.6 hits per line