kobotoolbox / kpi / 14469071096

81%

master: 76%

push

github

refactor(attachments): match FE to the updated response for submission attachments TASK-1778 (#5671)

### 💭 Notes

Update to match #5642 

Updated via changing the `SubmissionAttachment` type in
`dataInterface.ts`. Compiler blows up and I cleaned up the mess.

I updated the mock responses by copying the `xform_id_string` then
changed the last character. Seems more reasonable and better solution
than turning the old mocked `id` to a stringified version of the
integer.

`npm run test` and `npx jest --config ./jsapp/jest/unit.config.ts`
passes.

### 👀 Preview steps
<!-- Delete this section if behavior can't change. -->
<!-- If behavior changes or merely may change, add a preview of a
minimal happy path. -->

🟢 Make sure everywhere that needed this update "works as it should" 🤷 

AFAIK it seems to be these areas:
- Attachment dropdown (I believe this is broken in the single submission
modal as of this edit)
- Attachment dropdown stories
- Media cells
- Single submission modal
- Single submission view sidebar
- Form gallery

6135 of 9743 branches covered (62.97%)

23460 of 28971 relevant lines covered (80.98%)

1.6 hits per line