rust-bitcoin / rust-bitcoin / 13726075219

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4127: units: Prevent casting pub enums as ints

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/97453ef9bc2b99a67252419ff015f13679df7312">97453ef9b units: Prevent casting pub enums as ints (Tobin C. Harding)

Pull request description:

  A public enum with simple variants gets an automatic integer variant that can be cast by library consumers. This puts a unnecessary maintenance burden upon us because we cannot then add variants in the middle of others.

  Add a hidden variant to the single public non-error enum in `units`.

ACKs for top commit:
  Kixunil:
    ACK 97453ef9bc2b99a67252419ff015f13679df7312
  apoelstra:
    ACK 97453ef9bc2b99a67252419ff015f13679df7312; successfully ran local tests

Tree-SHA512: 251515210719da7a3932dbe4df13b39cc9c

21574 of 25992 relevant lines covered (83.0%)

16730.81 hits per line