rust-bitcoin / rust-bitcoin / 13725067989

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4085: Remove the `GeneralHash` trait

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/95ad91cdb64c8870d3eb992090bab7a70d1369b9">95ad91cdb<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5581c49e0f3847ad7171ae95ba0c26d7d094ab0d"> hashes: Remove the GeneralHash trait (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6426e59c63074fa48a6508ef6687199b46143d44">6426e59c6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5581c49e0f3847ad7171ae95ba0c26d7d094ab0d"> Remove unused trait import (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/791501eabc4ba000d194301e816aa27f8cc6be5d">791501eab</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5581c49e0f3847ad7171ae95ba0c26d7d094ab0d"> io: Use function in place of GeneralHashExt (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2b6ef31469edd93d59655afa41f3130f3ab058ba">2b6ef3146</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5581c49e0f3847ad7171ae95ba0c26d7d094ab0d"> hashes: Add hash_byte_chunks function to modules (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d3846895d790e4782795afc4b83130bc7d73de7d">d3846895d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5581c49e0f3847ad7171ae95ba0c26d7d094ab0d"> hashes: Add hash function to modules (Tobin C. Harding)
e1bac7da5 Bound HmacEngine on HashEngine (Tobin C. Harding)
ab63b7a0f Add Hash type and finalize method to HashEngine (Tobin C. Harding)
84623ffaf Add hash_again regression test (Tobin C. Harding)

Pull request description:

  This is the done as part of #4051.

  Requires some surgery on the `Hmac` and `Hkdf` types as well as a few other patches to maintain the logic that is currently provided by the trait. Final patch is a pure red diff - enjoy.

ACKs for top commit:
  Kixunil:
    ACK 95ad91cdb64c8870d3eb992090bab7a70d1369b9
  apoelstra:
    ACK 95ad91cdb64c8870d3eb992090bab7a70d1369b9; successfully ran local tests

Tree-SHA512: bfd215de5876fe377544a82c384a5bb8c2f

96 of 131 new or added lines in 17 files covered. (73.28%)

21574 of 25992 relevant lines covered (83.0%)

16660.67 hits per line