rust-bitcoin / rust-bitcoin / 13732459809

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4197: Take `spent` closure by value in `count_witness_sigops`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ae0ba6c1356505697fc5e841741ac488538e3407">ae0ba6c13 Take spent closure by value in count_witness_sigops and count_p2sh_sigops (jrakibi)

Pull request description:

  This fixes #4141

  Changed `count_witness_sigops` to take the `spent` closure by value instead of `&mut`
  This removes the need for `&mut` when calling the function while still allowing mutable closure to be passed when needed

ACKs for top commit:
  Kixunil:
    ACK ae0ba6c1356505697fc5e841741ac488538e3407
  tcharding:
    ACK ae0ba6c1356505697fc5e841741ac488538e3407
  apoelstra:
    ACK ae0ba6c1356505697fc5e841741ac488538e3407; successfully ran local tests

Tree-SHA512: 76c5c989929a67889c772d65b040d2ac84f

3 of 3 new or added lines in 1 file covered. (100.0%)

21574 of 25992 relevant lines covered (83.0%)

16692.1 hits per line