kobotoolbox / kpi / 13200267817

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(submissions): verify submission exists before adding or modifying extras (#5491)

### 📣 Summary
Return 404 when retrieving or updating submission extras if submission
does not exist.

### 💭 Notes
Update the GET and POST endpoints for submission extras to check that an
`Instance` with the given `uuid` exists, otherwise 404. We can't enforce
this at a database level because `SubmissionExtra`s and `Instance`s live
in different databases, but this at least provides some gating to
prevent us from having orphaned `SubmissionExtra`s lying around. It also
will make project history logs easier if we can ensure that we always
have an `Instance` containing information about the updated submission.


Bug template:
1. ℹ️ have an account and a project
2. In Django admin, add English (code 'en') as a language
3. Add an audio question to the project with the label "audio"
4. Create a submission to the project including an audio upload
5. Add a transcript to the submission
6. From the terminal, run `curl -X POST -H 'Authorization: Token <your
token>' -H 'Content-type: application/json'
kf.kobo.local:8080/advanced_submission_post/<asset_uid> -d
'{"submission": "bad-uuid", {"audio": {"transcript":
{"languageCode":"en", "value":"something"}}}}'`
7. 🔴 [on main] The request will succeed. In the shell, you will see a
SubmissionExtra object with a `submission_uuid` of `"bad-uuid"`
8. In the browser, go to
`kf.kobo.local:8080/advanced_submission_post/<asset_uid>?submission="also-bad"`
9. :red_circle: [on main] The response will be a 200 (though it will say
in the info that the submission doesn't exist)
10. 🟢 [on PR] Both requests will 404

Run Details

5972 of 9522 branches covered (62.72%)

5 of 5 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

22690 of 28144 relevant lines covered (80.62%)

0.81 hits per line