13012261930
62%

Ran 28 Jan 2025 07:35PM UTC

Jobs 1

Files 721

Run time 3min

Badge

Embed ▾

Committed 28 Jan 2025 02:09PM UTC coverage: 73.991% (+8.6%) from 65.396%

Build # 13012261930

Build Type

push

github

Committed by

web-flow

Commit Message

feat: keep keys in compressed form (#6753)

Description
---
Keeps all crypto public keys in compressed form, and only uncompressing
when needed.

Motivation and Context
---
This should improve speed and reduce the compression of keys. Comparing
unit test speeds this PR is roughly the same as before. But unit test
almost always do crypto operations to ensure everything is correct.
Where this PR increases performance is when only reading something and
providing it. For example, just reading the mainnet gen block in its
current form on avg it takes 56 seconds. With this pr this time is taken
down to on avg 15 seconds. Thats a 370% speed improvement.

How Has This Been Tested?
---
unit tests

Run Details

1623 of 2110 new or added lines in 123 files covered. (76.92%)

335 existing lines in 28 files now uncovered.

83511 of 112867 relevant lines covered (73.99%)

273339.14 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	17.5	0.0%	base_layer/core/src/base_node/comms_interface/comms_request.rs
1	65.08	0.06%	base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
1	79.9	0.0%	base_layer/core/src/blocks/accumulated_data.rs
1	96.98	0.02%	base_layer/core/src/proto/transaction.rs
1	70.59	0.0%	base_layer/core/src/proto/types_impls.rs
1	65.52	6.21%	base_layer/core/src/transactions/transaction_components/output_features.rs
1	97.37	-2.63%	base_layer/core/src/transactions/transaction_components/side_chain/validator_node_signature.rs
1	89.11	4.85%	base_layer/core/src/transactions/transaction_components/transaction_output.rs
1	92.86	92.86%	base_layer/core/src/transactions/transaction_protocol/proto/transaction_metadata.rs
1	98.03	1.23%	base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
1	16.0	-0.33%	base_layer/core/src/validation/error.rs
1	52.38	52.38%	base_layer/wallet/src/output_manager_service/input_selection.rs
1	64.5	64.5%	base_layer/wallet/src/output_manager_service/storage/database/mod.rs
1	74.82	61.34%	base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
1	62.5	0.0%	infrastructure/tari_script/src/script_context.rs
2	14.61	0.0%	base_layer/contacts/src/contacts_service/handle.rs
2	0.0	0.0%	base_layer/contacts/src/contacts_service/storage/database.rs
2	27.71	-0.34%	base_layer/core/src/chain_storage/error.rs
2	88.48	-0.37%	base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
2	75.06	0.0%	base_layer/core/src/transactions/aggregated_body.rs
2	96.22	0.01%	base_layer/core/src/transactions/test_helpers.rs
2	0.0	0.0%	base_layer/core/src/transactions/transaction_components/unblinded_output.rs
2	57.45		base_layer/core/src/transactions/transaction_key_manager/memory_db_key_manager.rs
2	87.5		base_layer/core/src/transactions/transaction_key_manager/schema.rs
2	47.79	15.04%	base_layer/wallet/src/storage/sqlite_utilities/mod.rs
2	90.85	0.47%	comms/core/src/peer_manager/identity_signature.rs
2	81.25	0.15%	comms/dht/src/store_forward/saf_handler/task.rs
3	0.0	0.0%	base_layer/contacts/src/contacts_service/types/message_dispatch.rs
3	22.42	0.0%	base_layer/core/src/base_node/comms_interface/local_interface.rs
3	15.79	15.79%	base_layer/core/src/transactions/transaction_components/error.rs
3	77.61		base_layer/core/src/transactions/transaction_key_manager/wrapper.rs
3	52.94	-5.12%	base_layer/core/src/transactions/transaction_protocol/mod.rs
4	1.56	0.0%	base_layer/contacts/src/contacts_service/service.rs
4	48.34	21.01%	base_layer/wallet/src/storage/database.rs
5	0.0	0.0%	base_layer/core/src/proto/sidechain_feature.rs
6	0.0	0.0%	applications/minotari_app_utilities/src/utilities.rs
6	12.12	12.12%	base_layer/common_types/src/wallet_types.rs
9	97.81	0.04%	infrastructure/tari_script/src/script.rs
10	64.69	-0.07%	base_layer/core/src/chain_storage/blockchain_database.rs
11	68.39	-0.89%	base_layer/core/src/transactions/transaction_components/wallet_output.rs
13	81.16		base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/imported_keys.rs
14	0.0	0.0%	base_layer/wallet/src/wallet.rs
15	74.16	8.98%	base_layer/core/src/transactions/transaction_components/wallet_output_builder.rs
15	0.0		base_layer/core/src/transactions/transaction_key_manager/error.rs
15	42.07	42.07%	base_layer/wallet/src/output_manager_service/handle.rs
23	45.47	45.47%	base_layer/wallet/src/transaction_service/handle.rs
25	0.0	0.0%	applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
25	70.49		base_layer/core/src/transactions/transaction_key_manager/interface.rs
25	77.06		base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/key_manager_state.rs
31	84.95		base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
32	77.14		base_layer/core/src/transactions/transaction_key_manager/key_manager.rs
35	57.97	57.97%	base_layer/wallet/src/transaction_service/service.rs
40	62.51		base_layer/core/src/transactions/transaction_key_manager/inner.rs
70	47.71	47.71%	base_layer/wallet/src/output_manager_service/service.rs

Uncovered Existing Lines

Lines	Coverage	∆	File
1	65.08	0.06%	base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
1	0.0	0.0%	base_layer/wallet/src/wallet.rs
1	80.0	-20.0%	comms/core/src/connectivity/error.rs
1	88.48	-0.37%	base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
1	73.2	0.11%	base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
1	0.0	0.0%	applications/minotari_app_utilities/src/utilities.rs
1	81.74	0.0%	comms/core/src/connection_manager/dialer.rs
1	95.91	-0.45%	comms/core/src/protocol/negotiation.rs
2	85.91	-0.91%	base_layer/p2p/src/services/liveness/state.rs
2	90.85	0.47%	comms/core/src/peer_manager/identity_signature.rs
2	0.0	0.0%	applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
2	80.16	-0.54%	comms/core/src/connection_manager/peer_connection.rs
3	97.81	0.04%	infrastructure/tari_script/src/script.rs
3	47.71	47.71%	base_layer/wallet/src/output_manager_service/service.rs
4	85.42	-0.29%	comms/dht/src/actor.rs
5	65.81	-4.27%	base_layer/key_manager/src/key_manager_service/interface.rs
5	66.36	-2.34%	comms/core/src/protocol/messaging/protocol.rs
6	62.17	-0.74%	comms/core/src/connectivity/manager.rs
6	84.42	-3.02%	comms/core/src/protocol/messaging/outbound.rs
7	43.75	-43.75%	base_layer/key_manager/src/schema.rs
8	87.32	-1.66%	base_layer/p2p/src/services/liveness/service.rs
8	65.91	-2.27%	comms/core/src/connectivity/requester.rs
15	64.55	-1.72%	comms/dht/src/connectivity/mod.rs
18	60.54	-12.24%	base_layer/key_manager/src/key_manager.rs
21	0.0	-87.5%	base_layer/key_manager/src/key_manager_service/storage/database/mod.rs
43	37.61	-39.45%	base_layer/key_manager/src/key_manager_service/storage/sqlite_db/key_manager_state.rs
62	0.0	-82.67%	base_layer/key_manager/src/key_manager_service/storage/sqlite_db/imported_keys.rs
105	21.84	-50.97%	base_layer/key_manager/src/key_manager_service/storage/sqlite_db/mod.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	13012261930.1	28 Jan 2025 07:35PM UTC	721	73.99	GitHub Action Run

tari-project / tari / 13012261930
62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13012261930

tari-project / tari / 13012261930 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 13012261930

tari-project / tari / 13012261930
62%

README BADGES
x