tari-project / tari / 13026118674

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: fix mempool sync start early (#6767)

Description
---
Mempool sync can only start when `is_synced` is set to `true`.
- An edge case was witnessed whereby mempool sync can start early if the
entire network is generally
slow to respond to pings. The `ChainMetadataEvent::NetworkSilence` event
is transmitted if 3x
consecutive ping cycles were started without corresponding pongs
received, which sets
`is_synced` to `true`. The moment that peer metadata is then received,
block sync and mempool sync
will occur at the same time. 
- Prolonged network silence is now detected in the `Starting` state. At
startup, the first successful metadata message received from a peer will
signal the transition to `Listening`, otherwise `Listening` will be
notified of the network silence, which can act accordingly.
- Additional debug logs were added to track all events that can set the
`is_synced` to `true`.
- Removed `log-mdc` from the dependencies as the relevant code is not
used.

The edge case warning message must be monitored to see if it is a real
issue:
```rust
warn!(
    target: LOG_TARGET,
    "Initial sync achieved based on event 'NetworkSilence'; this may not be true if the entire \
    network in general is slow to respond to pings"
);
```

Fixes #6766

Motivation and Context
---
Mempool sync _"started"_ before block sync was achieved.

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code review
System-level testing

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking... (continued)

Run Details

33 of 70 new or added lines in 7 files covered. (47.14%)

59 existing lines in 15 files now uncovered.

83447 of 112850 relevant lines covered (73.95%)

276136.87 hits per line