13012261930

Committed 28 Jan 2025 02:09PM UTC coverage: 73.991% (+8.6%) from 65.396%

Build # 13012261930

Build Type

push

github

Committed by

web-flow

Commit Message

feat: keep keys in compressed form (#6753)

Description
---
Keeps all crypto public keys in compressed form, and only uncompressing
when needed.

Motivation and Context
---
This should improve speed and reduce the compression of keys. Comparing
unit test speeds this PR is roughly the same as before. But unit test
almost always do crypto operations to ensure everything is correct.
Where this PR increases performance is when only reading something and
providing it. For example, just reading the mainnet gen block in its
current form on avg it takes 56 seconds. With this pr this time is taken
down to on avg 15 seconds. Thats a 370% speed improvement.

How Has This Been Tested?
---
unit tests

Coverage Stats

1623 of 2110 new or added lines in 123 files covered. (76.92%)

335 existing lines in 28 files now uncovered.

83511 of 112867 relevant lines covered (73.99%)

273339.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.0

/base_layer/core/src/validation/error.rs

// Copyright 2019. The Tari Project
//
// Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
// following conditions are met:
//
// 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following
// disclaimer.
//
// 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the
// following disclaimer in the documentation and/or other materials provided with the distribution.
//
// 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote
// products derived from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
// INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
// WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
// USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

use tari_common_types::types::HashOutput;
use tari_utilities::ByteArrayError;
use thiserror::Error;

use crate::{
    blocks::{BlockHeaderValidationError, BlockValidationError},
    chain_storage::ChainStorageError,
    common::{BanPeriod, BanReason},
    covenants::CovenantError,
    proof_of_work::{monero_rx::MergeMineError, DifficultyError, PowError},
    transactions::{
        tari_amount::MicroMinotari,
        transaction_components::{OutputType, RangeProofType, TransactionError},
    },
};

#[derive(Debug, Error)]
pub enum ValidationError {
    #[error("Serialization failed: {0}")]
    SerializationError(String),
    #[error("Block header validation failed: {0}")]
    BlockHeaderError(#[from] BlockHeaderValidationError),
    #[error("Block validation error: {0}")]
    BlockError(#[from] BlockValidationError),
    #[error("Contains kernels or inputs that are not yet spendable")]
    MaturityError,
    #[error("The block weight ({actual_weight}) is above the maximum ({max_weight})")]
    BlockTooLarge { actual_weight: u64, max_weight: u64 },
    #[error("Contains {} unknown inputs", .0.len())]
    UnknownInputs(Vec<HashOutput>),
    #[error("Contains an unknown input")]
    UnknownInput,
    #[error("The transaction is invalid: {0}")]
    TransactionError(#[from] TransactionError),
    #[error("Fatal storage error during validation: {0}")]
    FatalStorageError(String),
    #[error(
        "The total expected supply plus the total accumulated (offset) excess does not equal the sum of all UTXO \
         commitments."
    )]
    InvalidAccountingBalance,
    #[error("Transaction contains already spent inputs")]
    ContainsSTxO,
    #[error("Transaction contains outputs that already exist")]
    ContainsTxO,
    #[error("Transaction contains an output commitment that already exists")]
    ContainsDuplicateUtxoCommitment,
    #[error("Final state validation failed: The UTXO set did not balance with the expected emission at height {0}")]
    ChainBalanceValidationFailed(u64),
    #[error("The total value + fees of the block exceeds the maximum allowance on chain")]
    CoinbaseExceedsMaxLimit,
    #[error("Proof of work error: {0}")]
    ProofOfWorkError(#[from] PowError),
    #[error("Attempted to validate genesis block")]
    ValidatingGenesis,
    #[error("Duplicate or unsorted input found in block body")]
    UnsortedOrDuplicateInput,
    #[error("Duplicate or unsorted output found in block body")]
    UnsortedOrDuplicateOutput,
    #[error("Duplicate or unsorted kernel found in block body")]
    UnsortedOrDuplicateKernel,
    #[error("Error in merge mine data:{0}")]
    MergeMineError(#[from] MergeMineError),
    #[error("Maximum transaction weight exceeded")]
    MaxTransactionWeightExceeded,
    #[error("Expected block height to be {expected}, but was {block_height}")]
    IncorrectHeight { expected: u64, block_height: u64 },
    #[error("Expected block previous hash to be {expected}, but was {block_hash}")]
    IncorrectPreviousHash { expected: String, block_hash: String },
    #[error("Bad block with hash {hash} found")]
    BadBlockFound { hash: String, reason: String },
    #[error("Script exceeded maximum script size, expected less than {max_script_size} but was {actual_script_size}")]
    TariScriptExceedsMaxSize {
        max_script_size: usize,
        actual_script_size: usize,
    },
    #[error(
        "Encrypted data exceeded maximum encrytped data size, expected less than {max_encrypted_data_size} but was \
         {actual_encrypted_data_size}"
    )]
    EncryptedDataExceedsMaxSize {
        max_encrypted_data_size: usize,
        actual_encrypted_data_size: usize,
    },
    #[error("Consensus Error: {0}")]
    ConsensusError(String),
    #[error("Duplicate kernel Error: {0}")]
    DuplicateKernelError(String),
    #[error("Covenant failed to validate: {0}")]
    CovenantError(#[from] CovenantError),
    #[error("Invalid or unsupported blockchain version {version}")]
    InvalidBlockchainVersion { version: u16 },
    #[error("Contains Invalid Burn: {0}")]
    InvalidBurnError(String),
    #[error("Output type '{output_type}' is not permitted")]
    OutputTypeNotPermitted { output_type: OutputType },
    #[error("Range proof type '{range_proof_type}' is not permitted")]
    RangeProofTypeNotPermitted { range_proof_type: RangeProofType },
    #[error("Output type '{output_type}' is not matched to any range proof type")]
    OutputTypeNotMatchedToRangeProofType { output_type: OutputType },
    #[error("Validator registration has invalid minimum amount {actual}, must be at least {min}")]
    ValidatorNodeRegistrationMinDepositAmount { min: MicroMinotari, actual: MicroMinotari },
    #[error("Validator registration has invalid maturity {actual}, must be at least {min}")]
    ValidatorNodeRegistrationMinLockHeight { min: u64, actual: u64 },
    #[error("Validator node registration signature failed verification")]
    InvalidValidatorNodeSignature,
    #[error(
        "An unexpected number of timestamps were provided to the header validator. THIS IS A BUG. Expected \
         {expected}, got {actual}"
    )]
    IncorrectNumberOfTimestampsProvided { expected: u64, actual: u64 },
    #[error("Invalid difficulty: {0}")]
    DifficultyError(#[from] DifficultyError),
    #[error("Covenant too large. Max size: {max_size}, Actual size: {actual_size}")]
    CovenantTooLarge { max_size: usize, actual_size: usize },
    #[error("Invalid Transaction: {0}")]
    ByteArrayError(#[from] ByteArrayError),
}

// ChainStorageError has a ValidationError variant, so to prevent a cyclic dependency we use a string representation in
// for storage errors that cause validation failures.
impl From<ChainStorageError> for ValidationError {
    fn from(err: ChainStorageError) -> Self {
        Self::FatalStorageError(err.to_string())
    }
}

impl ValidationError {
    pub fn get_ban_reason(&self) -> Option<BanReason> {
        match self {
            ValidationError::ProofOfWorkError(e) => e.get_ban_reason(),
            err @ ValidationError::SerializationError(_) |
            err @ ValidationError::BlockHeaderError(_) |
            err @ ValidationError::BlockError(_) |
            err @ ValidationError::MaturityError |
            err @ ValidationError::BlockTooLarge { .. } |
            err @ ValidationError::UnknownInputs(_) |
            err @ ValidationError::UnknownInput |
            err @ ValidationError::TransactionError(_) |
            err @ ValidationError::InvalidAccountingBalance |
            err @ ValidationError::ContainsSTxO |
            err @ ValidationError::ContainsTxO |
            err @ ValidationError::ContainsDuplicateUtxoCommitment |
            err @ ValidationError::ChainBalanceValidationFailed(_) |
            err @ ValidationError::ValidatingGenesis |
            err @ ValidationError::UnsortedOrDuplicateInput |
            err @ ValidationError::UnsortedOrDuplicateOutput |
            err @ ValidationError::UnsortedOrDuplicateKernel |
            err @ ValidationError::MaxTransactionWeightExceeded |
            err @ ValidationError::IncorrectHeight { .. } |
            err @ ValidationError::IncorrectPreviousHash { .. } |
            err @ ValidationError::BadBlockFound { .. } |
            err @ ValidationError::TariScriptExceedsMaxSize { .. } |
            err @ ValidationError::EncryptedDataExceedsMaxSize { .. } |
            err @ ValidationError::ConsensusError(_) |
            err @ ValidationError::DuplicateKernelError(_) |
            err @ ValidationError::CovenantError(_) |
            err @ ValidationError::InvalidBlockchainVersion { .. } |
            err @ ValidationError::InvalidBurnError(_) |
            err @ ValidationError::OutputTypeNotPermitted { .. } |
            err @ ValidationError::RangeProofTypeNotPermitted { .. } |
            err @ ValidationError::OutputTypeNotMatchedToRangeProofType { .. } |
            err @ ValidationError::ValidatorNodeRegistrationMinDepositAmount { .. } |
            err @ ValidationError::ValidatorNodeRegistrationMinLockHeight { .. } |
            err @ ValidationError::InvalidValidatorNodeSignature |
            err @ ValidationError::DifficultyError(_) |
            err @ ValidationError::CoinbaseExceedsMaxLimit |
            err @ ValidationError::CovenantTooLarge { .. } |
            err @ ValidationError::ByteArrayError(_) => Some(BanReason {
                reason: err.to_string(),
                ban_duration: BanPeriod::Long,
            }),
            ValidationError::MergeMineError(e) => e.get_ban_reason(),
            ValidationError::FatalStorageError(_) | ValidationError::IncorrectNumberOfTimestampsProvided { .. } => None,
        }
    }
}

1	// Copyright 2019. The Tari Project
2	//
3	// Redistribution and use in source and binary forms, with or without modification, are permitted provided that the
4	// following conditions are met:
5	//
6	// 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following
7	// disclaimer.
8	//
9	// 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the
10	// following disclaimer in the documentation and/or other materials provided with the distribution.
11	//
12	// 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote
13	// products derived from this software without specific prior written permission.
14	//
15	// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
16	// INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17	// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
18	// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
19	// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
20	// WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
21	// USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
22
23	use tari_common_types::types::HashOutput;
24	use tari_utilities::ByteArrayError;
25	use thiserror::Error;
26
27	use crate::{
28	blocks::{BlockHeaderValidationError, BlockValidationError},
29	chain_storage::ChainStorageError,
30	common::{BanPeriod, BanReason},
31	covenants::CovenantError,
32	proof_of_work::{monero_rx::MergeMineError, DifficultyError, PowError},
33	transactions::{
34	tari_amount::MicroMinotari,
35	transaction_components::{OutputType, RangeProofType, TransactionError},
36	},
37	};
38
39	#[derive(Debug, Error)]
40	pub enum ValidationError {
41	#[error("Serialization failed: {0}")]
42	SerializationError(String),
43	#[error("Block header validation failed: {0}")]
44	BlockHeaderError(#[from] BlockHeaderValidationError),
45	#[error("Block validation error: {0}")]
46	BlockError(#[from] BlockValidationError),
47	#[error("Contains kernels or inputs that are not yet spendable")]
48	MaturityError,
49	#[error("The block weight ({actual_weight}) is above the maximum ({max_weight})")]
50	BlockTooLarge { actual_weight: u64, max_weight: u64 },
51	#[error("Contains {} unknown inputs", .0.len())]
52	UnknownInputs(Vec<HashOutput>),
53	#[error("Contains an unknown input")]
54	UnknownInput,
55	#[error("The transaction is invalid: {0}")]
56	TransactionError(#[from] TransactionError),
57	#[error("Fatal storage error during validation: {0}")]
58	FatalStorageError(String),
59	#[error(
60	"The total expected supply plus the total accumulated (offset) excess does not equal the sum of all UTXO \
61	commitments."
62	)]
63	InvalidAccountingBalance,
64	#[error("Transaction contains already spent inputs")]
65	ContainsSTxO,
66	#[error("Transaction contains outputs that already exist")]
67	ContainsTxO,
68	#[error("Transaction contains an output commitment that already exists")]
69	ContainsDuplicateUtxoCommitment,
70	#[error("Final state validation failed: The UTXO set did not balance with the expected emission at height {0}")]
71	ChainBalanceValidationFailed(u64),
72	#[error("The total value + fees of the block exceeds the maximum allowance on chain")]
73	CoinbaseExceedsMaxLimit,
74	#[error("Proof of work error: {0}")]
75	ProofOfWorkError(#[from] PowError),
76	#[error("Attempted to validate genesis block")]
77	ValidatingGenesis,
78	#[error("Duplicate or unsorted input found in block body")]
79	UnsortedOrDuplicateInput,
80	#[error("Duplicate or unsorted output found in block body")]
81	UnsortedOrDuplicateOutput,
82	#[error("Duplicate or unsorted kernel found in block body")]
83	UnsortedOrDuplicateKernel,
84	#[error("Error in merge mine data:{0}")]
85	MergeMineError(#[from] MergeMineError),
86	#[error("Maximum transaction weight exceeded")]
87	MaxTransactionWeightExceeded,
88	#[error("Expected block height to be {expected}, but was {block_height}")]
89	IncorrectHeight { expected: u64, block_height: u64 },
90	#[error("Expected block previous hash to be {expected}, but was {block_hash}")]
91	IncorrectPreviousHash { expected: String, block_hash: String },
92	#[error("Bad block with hash {hash} found")]
93	BadBlockFound { hash: String, reason: String },
94	#[error("Script exceeded maximum script size, expected less than {max_script_size} but was {actual_script_size}")]
95	TariScriptExceedsMaxSize {
96	max_script_size: usize,
97	actual_script_size: usize,
98	},
99	#[error(
100	"Encrypted data exceeded maximum encrytped data size, expected less than {max_encrypted_data_size} but was \
101	{actual_encrypted_data_size}"
102	)]
103	EncryptedDataExceedsMaxSize {
104	max_encrypted_data_size: usize,
105	actual_encrypted_data_size: usize,
106	},
107	#[error("Consensus Error: {0}")]
108	ConsensusError(String),
109	#[error("Duplicate kernel Error: {0}")]
110	DuplicateKernelError(String),
111	#[error("Covenant failed to validate: {0}")]
112	CovenantError(#[from] CovenantError),
113	#[error("Invalid or unsupported blockchain version {version}")]
114	InvalidBlockchainVersion { version: u16 },
115	#[error("Contains Invalid Burn: {0}")]
116	InvalidBurnError(String),
117	#[error("Output type '{output_type}' is not permitted")]
118	OutputTypeNotPermitted { output_type: OutputType },
119	#[error("Range proof type '{range_proof_type}' is not permitted")]
120	RangeProofTypeNotPermitted { range_proof_type: RangeProofType },
121	#[error("Output type '{output_type}' is not matched to any range proof type")]
122	OutputTypeNotMatchedToRangeProofType { output_type: OutputType },
123	#[error("Validator registration has invalid minimum amount {actual}, must be at least {min}")]
124	ValidatorNodeRegistrationMinDepositAmount { min: MicroMinotari, actual: MicroMinotari },
125	#[error("Validator registration has invalid maturity {actual}, must be at least {min}")]
126	ValidatorNodeRegistrationMinLockHeight { min: u64, actual: u64 },
127	#[error("Validator node registration signature failed verification")]
128	InvalidValidatorNodeSignature,
129	#[error(
130	"An unexpected number of timestamps were provided to the header validator. THIS IS A BUG. Expected \
131	{expected}, got {actual}"
132	)]
133	IncorrectNumberOfTimestampsProvided { expected: u64, actual: u64 },
134	#[error("Invalid difficulty: {0}")]
135	DifficultyError(#[from] DifficultyError),
136	#[error("Covenant too large. Max size: {max_size}, Actual size: {actual_size}")]
137	CovenantTooLarge { max_size: usize, actual_size: usize },
138	#[error("Invalid Transaction: {0}")]
139	ByteArrayError(#[from] ByteArrayError),
140	}
141
142	// ChainStorageError has a ValidationError variant, so to prevent a cyclic dependency we use a string representation in
143	// for storage errors that cause validation failures.
144	impl From<ChainStorageError> for ValidationError {
145	fn from(err: ChainStorageError) -> Self {	×
146	Self::FatalStorageError(err.to_string())	×
147	}	×
148	}
149
150	impl ValidationError {
151	pub fn get_ban_reason(&self) -> Option<BanReason> {	4✔
152	match self {	4✔
153	ValidationError::ProofOfWorkError(e) => e.get_ban_reason(),	×
154	err @ ValidationError::SerializationError(_) \|	×
155	err @ ValidationError::BlockHeaderError(_) \|	×
156	err @ ValidationError::BlockError(_) \|	×
157	err @ ValidationError::MaturityError \|	×
158	err @ ValidationError::BlockTooLarge { .. } \|	×
159	err @ ValidationError::UnknownInputs(_) \|	×
160	err @ ValidationError::UnknownInput \|	×
161	err @ ValidationError::TransactionError(_) \|	×
162	err @ ValidationError::InvalidAccountingBalance \|	×
163	err @ ValidationError::ContainsSTxO \|	×
164	err @ ValidationError::ContainsTxO \|	×
165	err @ ValidationError::ContainsDuplicateUtxoCommitment \|	×
166	err @ ValidationError::ChainBalanceValidationFailed(_) \|	×
167	err @ ValidationError::ValidatingGenesis \|	×
168	err @ ValidationError::UnsortedOrDuplicateInput \|	×
169	err @ ValidationError::UnsortedOrDuplicateOutput \|	×
170	err @ ValidationError::UnsortedOrDuplicateKernel \|	×
171	err @ ValidationError::MaxTransactionWeightExceeded \|	×
172	err @ ValidationError::IncorrectHeight { .. } \|	×
173	err @ ValidationError::IncorrectPreviousHash { .. } \|	×
174	err @ ValidationError::BadBlockFound { .. } \|	×
175	err @ ValidationError::TariScriptExceedsMaxSize { .. } \|	×
176	err @ ValidationError::EncryptedDataExceedsMaxSize { .. } \|	×
177	err @ ValidationError::ConsensusError(_) \|	4✔
178	err @ ValidationError::DuplicateKernelError(_) \|	×
179	err @ ValidationError::CovenantError(_) \|	×
180	err @ ValidationError::InvalidBlockchainVersion { .. } \|	×
181	err @ ValidationError::InvalidBurnError(_) \|	×
182	err @ ValidationError::OutputTypeNotPermitted { .. } \|	×
183	err @ ValidationError::RangeProofTypeNotPermitted { .. } \|	×
184	err @ ValidationError::OutputTypeNotMatchedToRangeProofType { .. } \|	×
185	err @ ValidationError::ValidatorNodeRegistrationMinDepositAmount { .. } \|	×
186	err @ ValidationError::ValidatorNodeRegistrationMinLockHeight { .. } \|	×
187	err @ ValidationError::InvalidValidatorNodeSignature \|	×
188	err @ ValidationError::DifficultyError(_) \|	×
189	err @ ValidationError::CoinbaseExceedsMaxLimit \|	×
NEW 190	err @ ValidationError::CovenantTooLarge { .. } \|	×
191	err @ ValidationError::ByteArrayError(_) => Some(BanReason {	4✔
192	reason: err.to_string(),	4✔
193	ban_duration: BanPeriod::Long,	4✔
194	}),	4✔
195	ValidationError::MergeMineError(e) => e.get_ban_reason(),	×
196	ValidationError::FatalStorageError(_) \| ValidationError::IncorrectNumberOfTimestampsProvided { .. } => None,	×
197	}
198	}	4✔
199	}

tari-project / tari / 13012261930

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous