skeema / skeema / 12728363597

92%

push

github

internal: refactor string manipulations of col types

This commit implements a long-overdue refactor of column data type handling
throughout the codebase. Previously, table introspection just obtained raw
column types from information_schema as strings, and left any parsing or
processing logic to each individual callsite. This caused a lot of redundant
code, especially among linter checks, as well as in the MODIFY COLUMN lossy-
change detection logic.

With this commit, at introspection time we now parse out the base type, size/
length/precision/scale/width fields, unsigned attribute, and zerofill
attribute. Regular expressions are not used, except in a few rare cases in
tests only.

197 of 197 new or added lines in 12 files covered. (100.0%)

10243 of 10983 relevant lines covered (93.26%)

1.11 hits per line