skeema / skeema / 12876819173

92%

push

github

introspection: reduce network transfer for routines

When introspecting routines (procs/funcs) from information_schema, the
routine body was previously queried from I_S.routines, as well as either
mysql.proc or SHOW CREATE. The version from I_S.routines was not used, as it
contains formatting/escaping problems in MySQL; and while it is correct in
MariaDB, it was still not used because the other sources (mysql.proc or SHOW
CREATE) still need to be queried anyway to obtain the param list efficiently.

This commit therefore removes routine_definition from the SELECT list when
querying information_schema.routines. For users with many routines and/or
large routine bodies, this change improves performance when operating over
a slow network link (WAN/VPN/cross-region).

This commit also refactors some older routine-related code to remove
unnecessary sprintf calls, make use of strings.Cut, make use of Go 1.22+ loop
variable scope change, use error wrapping, etc. A couple similar minor
refactors are also made to table introspection code.

31 of 35 new or added lines in 2 files covered. (88.57%)

10245 of 10986 relevant lines covered (93.26%)

1.11 hits per line