hydrologie / xhydro / 11692443276

92%

push

github

More flexible sampled_indicators (#220)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Multiple additions to `sampled_indicators` to make it more flexible:
* `delta_kind` can now be a dictionary and change per variable. It can
also be None, in which case it will search for a `delta_kind` attribute
in the variables (which is automatically added by
`xh.cc.compute_deltas`.
* Weights can be given along a `time` or `horizon` dimension. These
weights will be broadcast, but the dimension will not be stacked.
  * Added a bunch of missing attributes.

### Does this PR introduce a breaking change?

- `delta_type` was renamed `delta_kind` to be more consistent with
`xh.cc.compute_deltas`. It is now also no longer a positional argument
since it can be `None`.

### Other information:

56 of 56 new or added lines in 1 file covered. (100.0%)

2033 of 2150 relevant lines covered (94.56%)

2.84 hits per line