9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5
97%

Ran 07 Sep 2024 05:46PM UTC

Jobs 4

Files 155

Run time 1min

Badge

Embed ▾

Committed 07 Sep 2024 05:40PM UTC coverage: 93.866% (+0.2%) from 93.654%

Build # 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[REFACTOR] Remove redundant embargo code

**ISSUE**
The controller logic to parse embargo codes is only applied on
updates, but not new ETD creation. We didn't notice this because the
same functionality is provided in the actor stack, see:
https://github.com/curationexperts/laevigata/blob/v12.38.4/app/actors/hyrax/actors/etd_actor.rb#L24-L30

**RESOLUTION**
Since the actor stack logic applies in more contexts (background jobs, etc.)
including controller actions, we can safely remove the redundant
logic from the controller.

Run Details

3030 of 3228 relevant lines covered (93.87%)

52.48 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5.1	07 Sep 2024 05:46PM UTC	73.77
2	9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5.2	07 Sep 2024 05:46PM UTC	77.83
3	9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5.3	07 Sep 2024 05:46PM UTC	80.23
4	9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5.4	07 Sep 2024 05:46PM UTC	83.18

Source Files on build 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5

Detailed source file information is not available for this build.

curationexperts / laevigata / 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5

curationexperts / laevigata / 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5

curationexperts / laevigata / 9e3dfe8f-03f7-45d3-b9a0-0b219667e8a5
97%

README BADGES
x