9dd97c1e-7c61-4a5d-8488-23f75b0905af
97%

Ran 07 Sep 2024 07:28PM UTC

Jobs 4

Files 155

Run time 1min

Badge

Embed ▾

Committed 06 Sep 2024 05:52PM UTC coverage: 93.654% (+0.2%) from 93.438%

Build # 9dd97c1e-7c61-4a5d-8488-23f75b0905af

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[FIX] Embargo selections reset when editing ETDs

**ISSUE**
When a student or admin edits a submitted ETD, the "Content to Embargo"
setting is always reset to "Files Embargoed" regardless of what was
previously saved.

**DIAGNOSIS**
The library (and corresponding tests) that converts saved embargo
settings used a string values instead of boolean values. The source
ETD stores `files_embargoed`, `toc_embargoed`, and `abstract_embargoed`
as boolean values, bt the translation code was comparing against string
values. Examples:
```
true == 'true'
=> false

[true, true, false] == ['true', 'true', 'false']
=> false
```

**RESOLUTION**
Add test cases that demonstrate the bug and update the code to
do the comparisions using the correct data types.

Run Details

3040 of 3246 relevant lines covered (93.65%)

52.24 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	9dd97c1e-7c61-4a5d-8488-23f75b0905af.1	07 Sep 2024 07:28PM UTC	77.76
2	9dd97c1e-7c61-4a5d-8488-23f75b0905af.2	07 Sep 2024 07:28PM UTC	84.14
3	9dd97c1e-7c61-4a5d-8488-23f75b0905af.3	07 Sep 2024 07:29PM UTC	78.59
4	9dd97c1e-7c61-4a5d-8488-23f75b0905af.4	07 Sep 2024 07:29PM UTC	83.56

Source Files on build 9dd97c1e-7c61-4a5d-8488-23f75b0905af

Detailed source file information is not available for this build.

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9dd97c1e-7c61-4a5d-8488-23f75b0905af

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9dd97c1e-7c61-4a5d-8488-23f75b0905af

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af
97%

README BADGES
x