60cc5d27-63e1-403e-94e3-480f26a4500a
97%

Ran 06 Sep 2024 05:58PM UTC

Jobs 4

Files 155

Run time 1min

Badge

Embed ▾

Committed 06 Sep 2024 05:52PM UTC coverage: 93.654% (+0.2%) from 93.438%

Build # 60cc5d27-63e1-403e-94e3-480f26a4500a

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[FIX] Embargo selections reset when editing ETDs

**ISSUE**
When a student or admin edits a submitted ETD, the "Content to Embargo"
setting is always reset to "Files Embargoed" regardless of what was
previously saved.

**DIAGNOSIS**
The library (and corresponding tests) that converts saved embargo
settings used a string values instead of boolean values. The source
ETD stores `files_embargoed`, `toc_embargoed`, and `abstract_embargoed`
as boolean values, bt the translation code was comparing against string
values. Examples:
```
true == 'true'
=> false

[true, true, false] == ['true', 'true', 'false']
=> false
```

**RESOLUTION**
Add test cases that demonstrate the bug and update the code to
do the comparisions using the correct data types.

Run Details

3040 of 3246 relevant lines covered (93.65%)

52.23 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	60cc5d27-63e1-403e-94e3-480f26a4500a.1	06 Sep 2024 05:58PM UTC	77.9
2	60cc5d27-63e1-403e-94e3-480f26a4500a.2	06 Sep 2024 05:58PM UTC	82.28
3	60cc5d27-63e1-403e-94e3-480f26a4500a.3	06 Sep 2024 05:59PM UTC	79.35
4	60cc5d27-63e1-403e-94e3-480f26a4500a.4	06 Sep 2024 05:59PM UTC	80.84

Source Files on build 60cc5d27-63e1-403e-94e3-480f26a4500a

Detailed source file information is not available for this build.

curationexperts / laevigata / 60cc5d27-63e1-403e-94e3-480f26a4500a
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 60cc5d27-63e1-403e-94e3-480f26a4500a

curationexperts / laevigata / 60cc5d27-63e1-403e-94e3-480f26a4500a 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 60cc5d27-63e1-403e-94e3-480f26a4500a

curationexperts / laevigata / 60cc5d27-63e1-403e-94e3-480f26a4500a
97%

README BADGES
x