rust-bitcoin / rust-bitcoin / 10308637366

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3137: De-sugar `self`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/34e82125946475cf9255771ac76b27e5ec7b8066">34e821259 Replace &self with self: &Self (Tobin C. Harding)

Pull request description:

  `foo(&self)` is syntax sugar for `foo(self: &Self)`.

  The `define_extension_trait` is currently large, ugly, and not that expressive. If we use `self: &Self` then the macro is greatly simplified.

  (Also consuming version `self: Self`)

  De-sugar only, no logic changes.

ACKs for top commit:
  apoelstra:
    ACK 34e82125946475cf9255771ac76b27e5ec7b8066 successfully ran local tests; lol this looks so much better
  Kixunil:
    ACK 34e82125946475cf9255771ac76b27e5ec7b8066

Tree-SHA512: 7ec81bee9ceb89ecb0e3356d5106a27d9ad

8 of 8 new or added lines in 1 file covered. (100.0%)

19699 of 23673 relevant lines covered (83.21%)

15694.85 hits per line