rust-bitcoin / rust-bitcoin / 10309673316

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3140: primitives: Fix alloc feature

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3b5bcd098377b038aab4ffcb045d149b17e00534">3b5bcd098 primitives: Fix alloc feature (Tobin C. Harding)

Pull request description:

  We have an `alloc` feature but we are unconditionally using `extern crate alloc`, this is broken - clearly we need to add a `no-std` build for `primitives` in CI.

  Feature gate the `alloc` crate.

  While we are at it just pull types in from `alloc` in the `prelude` - I have no idea why we do not do this in `bitcoin`?

ACKs for top commit:
  Kixunil:
    ACK 3b5bcd098377b038aab4ffcb045d149b17e00534
  apoelstra:
    ACK 3b5bcd098377b038aab4ffcb045d149b17e00534 successfully ran local tests

Tree-SHA512: f042dfb36291a5dbb10ff48b52c5b114781

19699 of 23673 relevant lines covered (83.21%)

15664.1 hits per line