rust-bitcoin / rust-bitcoin / 10308016921

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2929: Introduce `ToU64` trait

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/579b76b7cbb08b7a367a6e5cfda5ab4c00fd5c05">579b76b7c Introduce ToU64 conversion trait (Tobin C. Harding)

Pull request description:

  The idea for this was pulled out of Steven's work in #2133

  We already explicitly do not support 16 bit machines.

  Also, because Rust supports `u182`s one cannot infallibly convert from a `usize` to a `u64`. This is unergonomic and results in a ton of casts.

  We can instead limit our code to running only on machines where `usize` is less that or equal to 64 bits then the infallible conversion is possible.

  Since 128 bit machines are not a thing yet this does not in reality introduce any limitations on the library.

  Add a "private" trait to the `internals` crate to do infallible conversion to a `u64` from `usize`.

  Implement it for all unsigned integers smaller than `u64` as well so we have the option to use the trait instead of `u32::from(foo)`.

ACKs for top commit:
  Kixunil:
    ACK 579b76b7cbb08b7a367a6e5cfda5ab4c00fd5c05
  apoelstra:
    ACK 579b76b7cbb08b7a367a6e5cfda5ab4c00fd5c05 successfully ran local tests

Tree-SHA512: 2eaddfff9e674e3a2c6f8203d72a4fa7f48

Coverage Stats

31 of 36 new or added lines in 14 files covered. (86.11%)

1 existing line in 1 file now uncovered.

19699 of 23673 relevant lines covered (83.21%)

15681.86 hits per line