rust-bitcoin / rust-bitcoin / 9235861730

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2765: Flesh out hex unit parsing API

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cf3e1eb198413a2a0ad80f15b8a1bf98ea52b4e0">cf3e1eb19<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d5399f881768c5f68a43ba0814a55470e125d01"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/98bf213c52c3639ee4b78a1ee573147340693ad5">98bf213c5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8d5399f881768c5f68a43ba0814a55470e125d01"> bitcoin: Remove error module (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a5b93cb1592eb24ff835cb128bf8dd42b72d68d2">a5b93cb15</a> Flesh out hex unit parsing API (Tobin C. Harding)

Pull request description:

  Add to `units::parse` the complete suit of hex unit parsing functions:

  - remove prefix
  - assert without prefix
  - parse with or without prefix
  - parse with prefix
  - parse without prefix
  - parse prefix unchecked

  Refactor `bitcoin` to use the exact function we need, removing code duplication.

  This is a breaking change to `units`, it does however keep the current re-exports from the public, now empty, `bitcoin::error` module.

ACKs for top commit:
  apoelstra:
    ACK cf3e1eb198413a2a0ad80f15b8a1bf98ea52b4e0

Tree-SHA512: 1778108d444d034a004bd53a8e3c1f02fe7

64 of 119 new or added lines in 5 files covered. (53.78%)

19320 of 23190 relevant lines covered (83.31%)

16739.62 hits per line