rust-bitcoin / rust-bitcoin / 9229716886

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2586: Hard code genesis script bytes instead of hex

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/726ff25c46b1aacbae7524c5fce7bb1da1fc8a59">726ff25c4<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d994aba063e2040ecbdcdc8d4252f7ac07b7d76a"> Hard code genesis script bytes instead of hex (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6e5592db7704635ca56c440739083630ff13d28d">6e5592db7</a> Use test_hex_unwrap in bench code (Tobin C. Harding)

Pull request description:

  Currently we have a dependency on `hex_lit` and it is used in exactly one place outside of test code, if we instead use a hardcoded array instead we can move the `hex_lit` dependency to `dev-dependencies`.

  Hard code the genesis block script bytes as an array of hex digits, link to the blockstream explorer for those interested and comment the bytes liberally since it took me a while to work out what they were.

  Move the `hex_lit` dependency and update the lock files.

ACKs for top commit:
  apoelstra:
    ACK 726ff25c46b1aacbae7524c5fce7bb1da1fc8a59

Tree-SHA512: 96110332f3b51b3545f9e1762550b86e574

1 of 1 new or added line in 1 file covered. (100.0%)

19312 of 23182 relevant lines covered (83.31%)

16751.52 hits per line