rust-bitcoin / rust-bitcoin / 9236033921

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2803: fuzz: delete CBOR test

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/830a6e1b0c57cc8b3a7a60fb0e1a61c1a4073654">830a6e1b0<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a43f9774db37bd3719604ffefc13431bf373a166"> fuzz: delete CBOR test (Andrew Poelstra)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/91eb50b2db14abcae5c0b0f5974f86c1bd50f1a6">91eb50b2d</a> fuzz: add lint to generate-files.sh (Andrew Poelstra)

Pull request description:

  We were using an outdated CBOR crate for MSRV reasons. But this old crate is causing suprious test failures. So delete it. (Sadly, updating the crate doesn't fix the issue, replacing it with ciborium breaks our MSRV tests because it needs a more recent `half` dependency, and replacing it with `minicbor` doesn't work because minicbor is not based on serde. So we don't really have any options.)

  In general, I am suspicious of this decode-then-reencode test. CBOR has some ambiguity in integer encoding. Empirically it has seemed to work for a long time, but this seems more like an indictment of our test than a positive result.

  Also, round-trip testing serde encoding of a byte vector is probably not a great use of our fuzz resources. I don't believe we have ever had a problem with this.

  Fixes #2801

ACKs for top commit:
  tcharding:
    ACK 830a6e1b0c57cc8b3a7a60fb0e1a61c1a4073654

Tree-SHA512: f207b68daf08ac1e950078dfc2154612a47

19320 of 23190 relevant lines covered (83.31%)

16747.79 hits per line