MITLibraries / transmogrifier / 9226189643

99%

push

github

Add 1st set of Datacite field methods (#178)

* Add 1st set of Datacite field methods

Why these changes are being introduced:
* Refactor Datacite to use field methods

How this addresses that need:
* Add comments to organize conftest.py by source
* Add additional Datacite fixtures to conftest.py
* Update datacite_record_all_fields.xml to align with other source fixtures
* Add create_datacite_source_record_stub function to Datacite test module
* Rename param xml > source_record
* Add field methods and associated private methods for alternate_titles, content_type, and contributors
* Add unit tests for new field methods
* Shift note-related code block from content_type to notes

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-284

* Updates based on discussion in PR #178

* Shift "or None" logic to field methods and update type hinting
* Update unit tests to all use stub records
* Remove unnecessary fixtures from conftest.py

* Further updates based on discussion in PR #178

* Add default value to create_datacite_source_record_stub's xml_insert param
* Replace calls of source_record_id variable with calls of get_source_record_id method inside field methods

* Update get_alternate_titles method

58 of 58 new or added lines in 1 file covered. (100.0%)

1426 of 1439 relevant lines covered (99.1%)

0.99 hits per line