MITLibraries / transmogrifier / 9276209988

99%

push

github

Field method refactor for OaiDc and SpringshareOaiDc transforms (#177)

Why these changes are being introduced:
* These updates are required to implement the architecture described
in the following ADR: https://github.com/MITLibraries/transmogrifier/blob/main/docs/adrs/0005-field-methods.md

How this addresses that need:
* Refactor base transform class OaiDc to contain get_*
methods for optional fields
* Make 'source_record' the first argument in OaiDc field methods
* Move 'or None' to the return statements of field methods
* Remove 'source_record_id' as param, replace with call inside field method instead
* Raise SkippedRecordEvent
  * OaiDc.get_source_record_id
  * SpringshareOaiDc.get_source_link
* Update unit tests
  * Remove OaiDc and SpringshareOaiDc record_* fixtures

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-283

68 of 68 new or added lines in 2 files covered. (100.0%)

1458 of 1471 relevant lines covered (99.12%)

0.99 hits per line