rust-bitcoin / rust-bitcoin / 8712108945

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2686: Fix kani codegen CI job

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0f0bd91929aa140ec6ba380316407552679cb9cf">0f0bd9192<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/87b674be45c0507368f5e48c694e485ae1772d26"> kani: Pin version to 0.48.0 (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5981b15902a444c295a980adb726ae94becf1c1d">5981b1590</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/87b674be45c0507368f5e48c694e485ae1772d26"> kani: Rename tests (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/17bacc6fb6e7fb92dcc4f4b5fdeecc3f756d72a3">17bacc6fb</a> kani: Remove redundant import (Tobin C. Harding)

Pull request description:

  Fix the current failing Kani job on todays PRs.

  FTR our daily `kani` job has been red for ages, perhaps since we created the `units` crate? But today the `--codege-only` job broke (on all PRs). `kani` released a new version 10 days ago, pinning to the previous version seems to resolve the issue. I raised a bug report but did not investigate further.

  - Patch 1: Remove redundant import
  - Patch 2: Rename the tests
  - Patch 3: Pin kani version

  File bug report: https://github.com/model-checking/kani/issues/3142

  PR is CI only, can go in with one ack.

  (Patch 2 is the result of debugging the _real_ kani failure we have at the moment, I'll save the rant for the PR that fixes it.)

ACKs for top commit:
  apoelstra:
    ACK 0f0bd91929aa140ec6ba380316407552679cb9cf though I wonder if we shoud comment out the test in rust.yml and file an issue
  sanket1729:
    utACK 0f0bd91929aa140ec6ba380316407552679cb9cf

Tree-SHA512: 1e510dd5365e4cd7d1a514292ac22faad29

19195 of 23090 relevant lines covered (83.13%)

16758.61 hits per line