rust-bitcoin / rust-bitcoin / 8689264293

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2677: Allow m prefix in derivation paths

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/830c1e9cfe047d611e55e4f1abdd37eea8571141">830c1e9cf Allow m prefix in derivation paths (Tobin C. Harding)

Pull request description:

  Recently in #2451 we disallowed bip32 derivation paths with the leading 'm' variable.

  There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call `getaddressinfo` returns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says.

  Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'.

  Leave the full investigation of the bip to a later date.

  Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.

  This PR replaces #2674.

ACKs for top commit:
  apoelstra:
    ACK 830c1e9cfe047d611e55e4f1abdd37eea8571141
  sanket1729:
    ACK 830c1e9cfe047d611e55e4f1abdd37eea8571141
  junderw:
    ACK 830c1e9cfe047d611e55e4f1abdd37eea8571141

Tree-SHA512: 7a4fccd49fead7b875336f8e934508c1615

37 of 37 new or added lines in 1 file covered. (100.0%)

19195 of 23090 relevant lines covered (83.13%)

16857.63 hits per line