rust-bitcoin / rust-bitcoin / 8721782431

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2687: Allow deprecated Params field

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/6e84548b1f65f5edb6e5fcf1a29ced80fa22a713">6e84548b1 Allow deprecated Params field (Tobin C. Harding)

Pull request description:

  I'm not sure why I haven't see this before during the whole test cycle but while running `cargo kani --only-codegen` we get a bunch of warnings of form:

    warning: use of deprecated field `consensus::params::Params::pow_limit`

  We deprecated the `pow_limit` field but still set it (obviously) in const structs - just shoosh the warning.

  Found while investigating the current kani CI failures.

ACKs for top commit:
  sanket1729:
    utACK 6e84548b1f65f5edb6e5fcf1a29ced80fa22a713

Tree-SHA512: b3fe9108e014c638032a3a57da9eeffeea0

19195 of 23090 relevant lines covered (83.13%)

16736.12 hits per line