7638890225
84%

Ran 24 Jan 2024 10:37AM UTC

Jobs 1

Files 534

Run time 35s

Badge

Embed ▾

Committed 24 Jan 2024 10:32AM UTC coverage: 81.437% (+0.002%) from 81.435%

Build # 7638890225

Build Type

push

github

Committed by

web-flow

Commit Message

refactor(oohelperd,netmx): reduce construction diff to zero (#1467)

This diff modifies how we construct oohelperd.Handler inside the
oohelperd package and inside the netemx package such that we're now
constructing using equivalent code. We know that construction is
equivalent for HTTP clients because previosuly we made sure it was the
case in https://github.com/ooni/probe-cli/pull/1464.

So, the next step would be removing the custom construction code inside
of netemx and always use oohelperd.NewHandler.

In turn, by doing this, we would ensure we have the same `oohelperd`
behavior for QA and production.

In turn, with this guarantee, we can write QA tests that ensure we're
correctly dealing with 127.0.0.1.

The reference issue is https://github.com/ooni/probe/issues/1517.

Run Details

25178 of 30917 relevant lines covered (81.44%)

50.17 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	0 - 7638890225.1	24 Jan 2024 10:37AM UTC	534	81.44	GitHub Action Run

ooni / probe-cli / 7638890225
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638890225

ooni / probe-cli / 7638890225 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638890225

ooni / probe-cli / 7638890225
84%

README BADGES
x