7638432121
72%

Ran 24 Jan 2024 09:59AM UTC

Jobs 1

Files 534

Run time 33s

Badge

Embed ▾

Committed 24 Jan 2024 09:55AM UTC coverage: 81.435% (-0.04%) from 81.471%

Build # 7638432121

Build Type

push

github

Committed by

web-flow

Commit Message

cleanup(netxlite): remove first-order implicit-Netx wrappers (#1465)

This diff removes the first-order implicit-Netx wrappers. We define
first-order implicit-Netx wrappers the top-level functions that have the
same name of netxlite.Netx methods, allocate an empty Netx, and call the
corresponding method.

The reason why we're doing this now is that it has been relatively hard
to implement https://github.com/ooni/probe-cli/pull/1464 because of the
ambiguity between those first-order wrappers and the methods. Getting
this wrong means that QA tests would behave in a funny way.

The overall goal here is to refactor `oohelperd` to only depend on
`netxlite.Netx` such that we can remove the code duplication between how
we instantiate `oohelperd.Handler` in `oohelperd` and how we instantiate
it inside `netemx`.

In turn, by doing this, we would ensure we have the same `oohelperd`
behavior for QA and production.

In turn, with this guarantee, we can write QA tests that ensure we're
correctly dealing with 127.0.0.1.

The reference issue is https://github.com/ooni/probe/issues/1517.

Run Details

25182 of 30923 relevant lines covered (81.43%)

52.86 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	0 - 7638432121.1	24 Jan 2024 09:59AM UTC	0	81.43	GitHub Action Run

Source Files on build 7638432121

Detailed source file information is not available for this build.

ooni / probe-cli / 7638432121
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638432121

ooni / probe-cli / 7638432121 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638432121

ooni / probe-cli / 7638432121
72%

README BADGES
x