7639089712
84%

Ran 24 Jan 2024 10:54AM UTC

Jobs 1

Files 534

Run time 35s

Badge

Embed ▾

Committed 24 Jan 2024 10:50AM UTC coverage: 81.422% (-0.02%) from 81.437%

Build # 7639089712

Build Type

push

github

Committed by

web-flow

Commit Message

refactor(netemx,oohelperd): use oohelperd.NewHandler constructor (#1468)

In https://github.com/ooni/probe-cli/pull/1467 we made the netemx
constructor for oohelperd.Handler equivalent to oohelperd.NewHandler.

So, now it becomes possible to always use oohelperd.NewHandler.

While there, notice that we can make all the Handler fields private
because there's no need to share them anymore, so do that.

Having done this, we are now sure we have the same `oohelperd` behavior
for QA and production.

In turn, with this guarantee, we can write QA tests that ensure we're
correctly dealing with 127.0.0.1.

The reference issue is https://github.com/ooni/probe/issues/1517.

Run Details

25153 of 30892 relevant lines covered (81.42%)

50.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	0 - 7639089712.1	24 Jan 2024 10:54AM UTC	534	81.42	GitHub Action Run

ooni / probe-cli / 7639089712
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7639089712

ooni / probe-cli / 7639089712 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7639089712

ooni / probe-cli / 7639089712
84%

README BADGES
x