ooni / probe-cli / 6274122024

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(enginenetx): refine the happy-eyeballs algorithm (#1296)

We want to pack attempts in parallel, which we also did before when the
interval between attempts was linear.

We need to take into account possible congestion, so we should push back
exponentially, even though the common case for us is probably censorship
(but it is better to do the right thing anyway).

So, let's scale exponentially until we reach 30s. After that, it's fine
to keep attempts evenly spaces, because 30s is quite definitely a huge
interval if we're reasoning in internet time.

Also, change the base value used for TLS handshaking to be 900ms rather
than 300ms, because a TLS handshake is ~3 round trips.

Part of https://github.com/ooni/probe/issues/2531

Run Details

14 of 14 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

23551 of 28871 relevant lines covered (81.57%)

29.33 hits per line