ooni / probe-cli / 6276220599

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(enginenetx): make static/loadable policy easier to use (#1297)

This diff makes the policy previously known as loadable and now know as
the static policy easier to use, by having a constructor that reads from
a key-value store and by passing it a fallback policy to use.

With this design, it should be possible to have code that uses the
static policy if applied, falling back to whatever policy we are
otherwise constructing into the NewNetwork constructor.

In a subsequent commit, I will hook this code into NewNetwork, so that
we can override the policy by changing the filesystem.

While there, notice several failures in the test suite and apply
workarounds (see https://github.com/ooni/probe/issues/2539,
https://github.com/ooni/probe/issues/2540,
https://github.com/ooni/probe/issues/2541).

Part of https://github.com/ooni/probe/issues/2531.

Run Details

34 of 34 new or added lines in 1 file covered. (100.0%)

26 existing lines in 7 files now uncovered.

23555 of 28899 relevant lines covered (81.51%)

27.55 hits per line