ooni / probe-cli / 6273720088

72%

push

github

feat(enginenetx): use the new HTTPSDialer (#1295)

This commit refactors how we construct the *Network used by the OONI
engine so that the HTTPSTransport we use relies on the new HTTPSDialer
as opposed to using netxlite's TLS dialing facilities.

This new HTTPSDialer has been specifically written to integrate TCP and
TLS dialing and facilitate circumvention.

The current implementation uses a "null" policy which makes it roughly
equivalent to the previous behavior, at least functionally, tough we are
now doing a variation of happy eyeballs where to try to ~aggressively
dial more connections as we see that previous connections fail to dial.

Specifically, if a TLS connection has not succeded within 300
milliseconds (probably a low value?), then we attempt dialing with
another available IP address.

The new code documents extensively what we are doing and some current
limitations, including references to the tracking issues.

This also diff fixes two issues we discovered when integrating the
HTTPSDialer with the rest of OONI Probe:

1. https://github.com/ooni/probe-cli/pull/1295#issuecomment-1731231178

2. https://github.com/ooni/probe-cli/pull/1295#issuecomment-1731243994

While there, use `log.Log` more frequently in testing to interpret what
is going wrong.

Part of https://github.com/ooni/probe/issues/2531

71 of 71 new or added lines in 10 files covered. (100.0%)

23532 of 28859 relevant lines covered (81.54%)

34.23 hits per line