• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 6149003698
69%

Build:
DEFAULT BRANCH: main
Ran 11 Sep 2023 04:17PM UTC
Jobs 2
Files 532
Run time 20s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Sep 2023 04:14PM UTC coverage: 69.325% (-0.002%) from 69.327%
6149003698

push

github

web-flow
check for ResizeObserver before using it (#709)

## Summary:
This is basically the same thing they're doing in Webapp, I just didn't notice it before.

Issue: LC-1213

## Test plan:
Not really sure how to write tests for this...maybe I could mock the whole `window` object and just not include `ResizeObserver`? Originally I was going to do something like `window.ResizeObserver = undefined`, but interestingly:

``` JS
window.ResizeObserver = undefined
console.log("ResizeObserver" in window) // true
```

I was able to manually test with `delete`

``` JS
delete window.ResizeObserver
console.log("ResizeObserver" in window) // false
```

Just wasn't sure how to translate that to tests.

Manually testing the regression though:
- Use a mobile web browser or emulate mobile
- Use a browser that doesn't support ResizeObserver (Safari <13.1)
- Go to a page with an [Expression widget](https://www.khanacademy.org/internal-courses/test-everything/test-everything-1/expression/e/expression-exercise)
- Note that rendering the exercise doesn't result in an error

Author: handeyeco

Reviewers: jeremywiebe

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald, ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x)

Pull Request URL: https://github.com/Khan/perseus/pull/709

7651 of 16646 branches covered (0.0%)

Branch coverage included in aggregate %.

11 of 15 new or added lines in 2 files covered. (73.33%)

71736 of 97868 relevant lines covered (73.3%)

709.74 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 jest 6149003698.1 11 Sep 2023 04:24PM UTC 0
63.31
GitHub Action Run
2 cypress 6149003698.2 11 Sep 2023 04:17PM UTC 0
26.11
GitHub Action Run
Source Files on build 6149003698
Detailed source file information is not available for this build.
  • Back to Repo
  • 3afc0da2 on github
  • Prev Build on main (#6148996521)
  • Next Build on main (#6149013791)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc