Khan / perseus / 6149013791

69%

push

github

Test Coveralls hanging indefinitely fix (#712)

## Summary:
The Coveralls action keeps hanging indefinitely.

<img width="911" alt="Screen Shot 2023-09-08 at 11 14 20 AM" src="https://github.com/Khan/perseus/assets/16308368/5ed46fc9-25a9-4c11-a1ed-01004cdc1ceb">

These are the links to those:
- [Coveralls - cypress](https://coveralls.io/jobs/127978310)
- [Coveralls - jest](https://coveralls.io/jobs/127978311)
- [coverage/coveralls](https://coveralls.io/builds/62515147)

I don't actually know anyone who looks at the Coverall coverage. So it's pretty much just an inconvenience at best and a potential drain on engineering resources at worst. I thought about getting rid of it, but we were having trouble with Codecov too (also something no one looked at); so I thought I'd attempt a fix.

I'm trying to find a link to the GH comment that made me think of this possible solution. The general idea is:
- We originally push the PR and Coveralls runs
- We run the workflow again when the base branch changes (usually `main`): "edited is needed because that's the trigger when the base branch is changed on a PR" ([Source](https://github.com/Khan/perseus/blob/main/.github/workflows/node-ci.yml#L5))
- Coveralls doesn't see that the feature branch changed and really it doesn't need to.
  - We want the tests to run again, to make sure the base and feature are compatible
  - Coverage of the PR isn't affected by the base changing really (right?); we're trying to understand if the PR reduced coverage, and if the the PR's code didn't change why should we recheck coverage?

So this fix basically is to only run Coveralls when we push changes (hopefully).

Author: handeyeco

Reviewers: jeremywiebe, kevinbarabash

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes... (continued)

7652 of 16646 branches covered (0.0%)

Branch coverage included in aggregate %.

71737 of 97868 relevant lines covered (73.3%)

709.8 hits per line