MITLibraries / carbon / 5976535136

94%

push

github

IN-886 Refactor Carbon app to use new Data Warehouse secret (#94)

* IN-886 Refactor Carbon app to use new Data Warehouse secret

Why these changes are being introduced:
* Use the JSON formatted secret in Secrets Manager to obtain
credentials for the Data Warehouse and remove redundant secrets.

How this addresses that need:
* Configure the engine with 'CONNECTION_STRING'
* Create database connection test and add CLI option to run test
* Add Make command to run database connection test
* Remove unused 'click.echo' commands
* Add error handling when retrieving database versions

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-886

---

* Address comments
* Update README
* Clean up variable name 'conn'
* Add docstring to DatabaseEngine.run_connection_test

36 of 36 new or added lines in 3 files covered. (100.0%)

273 of 282 relevant lines covered (96.81%)

0.97 hits per line