MITLibraries / carbon / 5980096596

94%

push

github

IN-887 Refactor Carbon app to use new Symplectic FTP parameters (#95)

* IN-887 Refactor Carbon app to use new Symplectic FTP parameters

Why these changes are being introduced:
* Simplify management of FTP credentials by storing
components in a JSON formatted string

How this addresses that need:
* Expand connection tests for Data Warehouse and Symplectic Elements FTP server
* Update CLI tests
* Update README

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-887

---

Address comments
* Update '_test_env' to use FTP server fixture
* Simplify test_load_config_values_success
* Fix use of 'feed_type' and 'symplectic_ftp_path' fixtures

17 of 17 new or added lines in 2 files covered. (100.0%)

289 of 295 relevant lines covered (97.97%)

0.98 hits per line