MITLibraries / carbon / 5952703237

94%

push

github

In 884 refactor config loading (#88)

* IN-884 Refactor method for loading configurations

Why these changes are being introduced:
* Simplify method for running Carbon ECS tasks by providing
environment variables through the 'secrets' and 'environment' blocks
and simplify function for loading configs.

How this addresses that need:
* Update references to environment variables by using revised names
* Replace 'Config' class with a method for loading configs
* Update 'test_env' to include new set of environment variables
* Simplify cli command and update tests accordingly
* Configure a logger that sends logs to CloudWatch
* Deprecate options in cli command
* Revise test_file_is_ftped to simply check for existence of
file on test FTP server
* Revise test_people_returns_people and test_articles_return_articles
to use test FTP server
* Add test_config


Side effects of this change:
* Revised names for environment variables (namely, appending
'SYMPLECTIC' prefix to FTP variables
* Click options are deprecated so ECS task definitions must also be updated

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-884

59 of 59 new or added lines in 3 files covered. (100.0%)

260 of 266 relevant lines covered (97.74%)

0.98 hits per line