Valloric / ycmd / 1712
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 42
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1712

push

travis-ci

homu 
Auto merge of #415 - puremourning:osx-include-dirs, r=micbou

[READY] Automatically include clang includes on OS X

OS X (by default) has 2 ways to set up development environment: Xcode.app and
installation of the CommandLineTools. As previously known, libclang does not
automatically add these system include paths as clang's own driver does.
Previously, ycmd would add the Xcode.app c++ include directories. This change
ensures that we add the system include paths when only the CommandLineTools are
installed (they are significantly lighter weight than xcode and installed
automatically when first attempting to run things like clang).

Additionally, around Xcode 7, additional include paths became required which are
located in versioned directories. These headers are clang-specific headers (such
as stddef.h). This change includes a mechanism to find such includes by
selecting the highest versioned set of headers that can be detected.

Fixes: https://github.com/Valloric/YouCompleteMe/issues/1992
Fixes: https://github.com/Valloric/ycmd/issues/304
Fixes: https://github.com/Valloric/ycmd/issues/254

Replaces: https://github.com/Valloric/ycmd/pull/385

I've tested this with Xcode 7 & Xcode 6 with and without the Command Line Tools. Admittedly I haven't tested the cartesian product of those configurations, but I'm fairly confident that this doesn't introduce a regression and does select a working set of includes on OS X. It shouldn't need fiddling after further changes by Apple either (hopefully!).

It's also worth noting that I believe a future change (waiting on upstream) by @d0k will make this hacking redundant, so we can remove it (yay!).

@indianajohn apologies, I didn't mean to clobber your work (I certainly used it for inspiration!), but this issue has been bugging me so I wanted to fix it anyway. Thanks for your work on it though!

(off topic note: it seems that the PR template is clobbered by the commit message when the PR is a single commit. FWIW - I'm aware of contributing guide/code of conduct, etc. :))

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/415)
<!-- Reviewable:end -->

2982 of 3537 relevant lines covered (84.31%)

0.84 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1712.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 0
84.31
 Travis Job 1712.1
Source Files on build 1712
Detailed source file information is not available for this build.