Valloric / ycmd / 1703
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 42
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1703

push

travis-ci

homu 
Auto merge of #410 - micbou:prepare-trigger-unicode, r=Valloric

[READY] Convert triggers to unicode before compiling them as a regex

Fixes Valloric/YouCompleteMe#2022.

Here's the full traceback from the error:
```python
Traceback (most recent call last):
  File "<string>", line 24, in <module>
  File "C:\\Users\\micbou\\.vim\\bundle\\YouCompleteMe\\autoload\..\python\ycm\setup.py", line 59, in SetUpYCM
    return YouCompleteMe( user_options_store.GetAll() )
  File "C:\\Users\\micbou\\.vim\\bundle\\YouCompleteMe\\autoload\..\python\ycm\youcompleteme.py", line 95, in __init__
    self._omnicomp = OmniCompleter( user_options )
  File "C:\\Users\\micbou\\.vim\\bundle\\YouCompleteMe\\autoload\..\python\ycm\omni_completer.py", line 38, in __init__
    super( OmniCompleter, self ).__init__( user_options )
  File "C:\Users\micbou\.vim\bundle\YouCompleteMe\python\ycm\..\..\third_party\ycmd\ycmd\completers\completer.py", line 113, in __init__
    if user_options[ 'auto_trigger' ] else None )
  File "C:\Users\micbou\.vim\bundle\YouCompleteMe\python\ycm\..\..\third_party\ycmd\ycmd\completers\completer_utils.py", line 38, in __init__
    dict( user_trigger_map ) ) if user_trigger_map else
  File "C:\Users\micbou\.vim\bundle\YouCompleteMe\python\ycm\..\..\third_party\ycmd\ycmd\completers\completer_utils.py", line 75, in _FiletypeTriggerDictFromSpec
    regexes = [ _PrepareTrigger( x ) for x in triggers ]
  File "C:\Users\micbou\.vim\bundle\YouCompleteMe\python\ycm\..\..\third_party\ycmd\ycmd\completers\completer_utils.py", line 138, in _PrepareTrigger
    if trigger.startswith( TRIGGER_REGEX_PREFIX ):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128)
```

This is the most straightforward way to fix the issue but not sure if it is the right place. This is why I put the `RFC` tag. I would also like to add tests for this.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/410)
<!-- Reviewable:end -->

2976 of 3516 relevant lines covered (84.64%)

0.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1703.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 0
84.64
 Travis Job 1703.1
Source Files on build 1703
Detailed source file information is not available for this build.