pantsbuild / pants / 8651
0%
main: 93%

LAST BUILD BRANCH: fix_uv_lockfile_sync
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8651

push

travis-ci

peiyuwang 
bundle_create cleanup: merge internal-libs and libs

We recently introduced a change that splits fat jar into per target jars and
places them under `internal-libs` (https://rbcommons.com/s/twitter/r/3261/)

The issue that we didn't anticipate as we prepare the new release is there are
ad-hoc scripts that hardcode `-cp libs/*` assuming all library jars are under
`libs` instead of using the monolithic jar with synthetic classpath.

Hopefully by merging `internal-libs` back to `libs` we will have less surprises
in the release.

Some implementation details:

- merge code that creates external symlinks and internal symlinks into one,
  hopefully simplies some logic
- to keep symlinks unique under libs, both external and internal jars follow
  the same naming style: prefixed with `target.id`, followed by a unique integer,
  this is for 1. unique-ness 2. cap the filename length. For example:

Was:
```
internal-libs/a.b.c-0.jar (target.id + index)
libs/com.google.guava-guava-18.0.jar (maven name)
```
Now:
```
libs/a.b.c-0.jar (target.id + index)
libs/3rdparty.guava-0.jar (also target.id + index)
```

Note: the other naming style for external jar considered is (target.id + maven name)
is easier for debugging, but has the risk of exceeding file name max length.

Sorry about this change, wish had realized this earlier!

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/101771438 passed

Bugs closed: 2793

Reviewed at https://rbcommons.com/s/twitter/r/3329/
Jobs
ID Job ID Ran Files Coverage
1 8651.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8651.1
4 8651.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8651.4
5 8651.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8651.5
6 8651.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8651.6
7 8651.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8651.7
8 8651.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8651.8
9 8651.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8651.9
10 8651.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8651.10
Source Files on build 8651
Detailed source file information is not available for this build.