8647
0%
main: 93%

Ran 15 Jan 2016 10:59PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8647

Build Type

push

travis-ci

Committed by

peiyuwang

Commit Message

Group classpath products by their targets

This review adds the convenient method `get_product_target_mappings_for_targets`,
to `UnionProducts` and `ClasspathProducts` to return products or classpath
products associated with their targets.

This is so that we can look up products for the targets their belong to.

Background:

https://rbcommons.com/s/twitter/r/3329/ attempts to create 3rdparty libraries
symlinks same way as internal libraries are created, for bundle. There are two
options:

1. get the classpath products for all targets in `binary.closure(bfs=True)` in
   one call `get_classpath_entries_for_targets`
2. make the same call multiple times for each target

The issue with (2) is it does not respect the excludes same as (1), because
excludes are transitive to their dependents.

This review will allow us after calling `get_classpath_entries_for_targets`,
get products' `target.id` for each products and make symlinks accordingly.

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/102419914

Bugs closed: 2807

Reviewed at https://rbcommons.com/s/twitter/r/3338/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8647.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	15 Jan 2016 10:59PM UTC	Travis Job 8647.1
4	8647.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	15 Jan 2016 11:32PM UTC	Travis Job 8647.4
5	8647.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	15 Jan 2016 11:07PM UTC	Travis Job 8647.5
6	8647.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	15 Jan 2016 11:08PM UTC	Travis Job 8647.6
7	8647.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	15 Jan 2016 11:10PM UTC	Travis Job 8647.7
8	8647.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	15 Jan 2016 11:10PM UTC	Travis Job 8647.8
9	8647.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	15 Jan 2016 11:20PM UTC	Travis Job 8647.9
10	8647.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	15 Jan 2016 11:20PM UTC	Travis Job 8647.10

Source Files on build 8647

Detailed source file information is not available for this build.

pantsbuild / pants / 8647
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8647

pantsbuild / pants / 8647 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8647

pantsbuild / pants / 8647
0%
main: 93%

README BADGES
x