pantsbuild / pants / 8518
0%
main: 93%

LAST BUILD BRANCH: tdyas/reapi/another-regression-test
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8518

push

travis-ci

Benjy 
Start the timeout *after* the process is spawned, drop the mutable process handler variable

Pants in source at Twitter has a relatively long gap between when the timeout timer is started and when the actual test runner process was launched, which meant that if a timeout (<30s) ran its course before the test runner process was launched, it would not be aborted, then it would launch, and run for however long.

This fixes that, primarily by refactoring per Benjy's suggestion in the prior RB, whereby the "spawn" returns a process handle that can then be used to kill/terminate, etc, and then the timeout wraps just the wait, rather than the spawn & wait.

Abstracting out the process spawner a bit *could* help a little with moving towards distributed test running, but may be mooted by the engine refactor.

Testing Done:
Succeed:

./pants test tests/python/pants_test/backend/jvm/tasks:junit_run
./pants test tests/python/pants_test/backend/python/tasks:pytest_run
./pants test tests/python/pants_test/backend/python/tasks:pytest_run_integration
./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration
./pants test tests/python/pants_test/task:testrunner_task_mixin
./pants test tests/python/pants_test/util:process_handler
build-support/bin/unit-test.sh

Ran a test to ensure output from Junit shows up:
./pants test --test-junit-output-mode=ALL testprojects/src/java/org/pantsbuild/testproject/junit/suppressoutput:tests

Added some timeouts and sleeps and saw these fail:

./pants test tests/python/pants_test/util:xml_parser
./pants test tests/java/org/pantsbuild/testing

Added a sleep(60) to `PytestRun._do_run_tests` inside the `self._test_runner` context to simulate Twitter python pants test launching slowness, set timeout=5 on util:xml_parser test:
./pants test tests/python/pants_test/util:xml_parser

Added sleep(10) to the util:xml_parser test to force a failure (with the above sleep still in there to continue to simulate Twitter python pants test launching slowness):
./pants test tests/python/pants_test/util:xml_parser

Added a sleep to EasyMockTest and did ^C during the run:
./pants test tests/java/org/pantsbuild/testing
saw ABORTED:

```
11:09:30 00:01       [run]
                     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
                     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option UseSplitVerifier; support was removed in 8.0
                     Auto-detected 8 processors, using -parallel-threads=8
                     ..^CINFO] killing nailgun server pid=97424
INFO] killing nailgun server pid=97426
INFO] killing nailgun server pid=98026

11:09:32 00:03   [complete]
               ABORTED
```

Travis: https://travis-ci.org/pantsbuild/pants/builds/100476390

Reviewed at https://rbcommons.com/s/twitter/r/3202/
Jobs
ID Job ID Ran Files Coverage
1 8518.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8518.1
4 8518.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8518.4
5 8518.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8518.5
6 8518.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8518.6
7 8518.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8518.7
8 8518.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8518.8
9 8518.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8518.9
10 8518.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8518.10
Source Files on build 8518
Detailed source file information is not available for this build.