8511
0%
main: 93%

Ran 05 Jan 2016 08:27PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8511

Build Type

push

travis-ci

Committed by

ericzundel

Commit Message

Adding sanity check for locale setting

If the environment had an invalid locale setting, Pants would fail deep inside a 3rdparty library.

This change adds an explicit test for a valid locale early in pants startup to give users better feedback about this setup problem.

Now an error like this prints:
```
Traceback (most recent call last):
  File "/Users/zundel/Src/Pants/src/python/pants/bin/pants_exe.py", line 35, in <module>
    "    LANG=en_US.UTF-8".format(type(e).__name__, e))
__main__.InvalidLocaleError: ValueError: unknown locale: ou812
  Could not get a valid locale. Check LC_* and LANG environment settings.
  Example for US English:
    LC_ALL=en_US.UTF-8
    LANG=en_US.UTF-8
```

Testing Done:
CI is green at https://travis-ci.org/pantsbuild/pants/builds/100367350
Added an integration test

Bugs closed: 2465, 2769

Reviewed at https://rbcommons.com/s/twitter/r/3296/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8511.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	05 Jan 2016 08:27PM UTC	Travis Job 8511.1
4	8511.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	05 Jan 2016 08:43PM UTC	Travis Job 8511.4
5	8511.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	05 Jan 2016 08:34PM UTC	Travis Job 8511.5
6	8511.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	05 Jan 2016 08:35PM UTC	Travis Job 8511.6
7	8511.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	05 Jan 2016 08:36PM UTC	Travis Job 8511.7
8	8511.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	05 Jan 2016 08:38PM UTC	Travis Job 8511.8
9	8511.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	05 Jan 2016 08:42PM UTC	Travis Job 8511.9
10	8511.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	05 Jan 2016 08:43PM UTC	Travis Job 8511.10

Source Files on build 8511

Detailed source file information is not available for this build.

pantsbuild / pants / 8511
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8511

pantsbuild / pants / 8511 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8511

pantsbuild / pants / 8511
0%
main: 93%

README BADGES
x