pantsbuild / pants / 7815
0%
main: 93%

LAST BUILD BRANCH: add/port-target-adaptor-and-source-block
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7815

push

travis-ci

jsirois 
Fix plugin option references in leaves.

9c2fc477 gave both `ProtobufGen` and `ZincCompile` their own `plugins`
options to not shadow the global `plugins` option, but the options
usages in those classes were not correspondingly updated.  This fixes
those usages.

Testing Done:
I noticed this upgrading Medium to `0.0.56`.  They use the go plugin
and so have the global `plugins` option defined.  This leads to:
```
...
19:39:20 00:00   [gen]
19:39:20 00:00     [thrift]
19:39:20 00:00     [protoc]
                   Invalidated 2 targets.DEBUG] Selected protoc binary bootstrapped to: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc

                     Executing: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc\
                       --java_out=/home/jsirois/dev/medium/mono/.pants.d/gen/protoc/src.main.protobuf.com.medium.proto.events.events/b9b0398038ee\
                       --pantsbuild.pants.contrib.go==0.0.56_out=/home/jsirois/dev/medium/mono/.pants.d/gen/protoc/src.main.protobuf.com.medium.proto.events.events/b9b0398038ee\
                       --proto_path=src/main/protobuf\
                       src/main/protobuf/com/medium/proto/events/events.protoUnknown flag: --pantsbuild.pants.contrib.go

19:39:20 00:00       [execute]
FAILURE: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc ... exited non-zero (1)

19:39:20 00:00   [complete]
               FAILURE
...
```

Green locally - proving no typos in the new options references
introduced:
```
$ ./pants test \
  tests/python/pants_test/tasks:protobuf_integration \
  tests/python/pants_test/backend/codegen/tasks:protobuf_gen \
  tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc:zinc_compile_integration
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/89771696

Bugs closed: 2521

Reviewed at https://rbcommons.com/s/twitter/r/3098/
Jobs
ID Job ID Ran Files Coverage
1 7815.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7815.1
4 7815.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7815.4
5 7815.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7815.5
6 7815.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7815.6
7 7815.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7815.7
8 7815.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7815.8
9 7815.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7815.9
10 7815.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7815.10
Source Files on build 7815
Detailed source file information is not available for this build.