7814
0%
main: 93%

Ran 07 Nov 2015 05:35AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7814

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

API Change: Move graph walking out of classpath_(util|products)

This patch removes all transitivity from `classpath_util` and `classpath_products`, in favor of doing external graph walks and then requesting products explicitly per target. This helps to separate concerns, rather than having APIs to specify walk modes living outside of the `build_graph` package.

One other thing this helps to do is make it more obvious where we are mixing classpaths for targets. There are still a few cases (junit, checkstyle, etc) where we collect a classpath for targets from potentially-disjoint subgraphs. And in those cases, you now need to do an explicit collection and merger of the classpath per target.

- Remove the `transitive` flag everywhere in `classpath_util` and `classpath_products`; do not walk.
- In checkstyle, only compute the classpath for relevant targets

The one awkward bit that I should call out is that `jvm_target.excludes` are still applied transitively by collecting all excludes below the target. But I expect that the right way to fix that in the long term will be to deprecate excludes in favor of `deploy_excludes`. Would be willing to do that here if we agree.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/89567540

Bugs closed: 2438

Reviewed at https://rbcommons.com/s/twitter/r/3036/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7814.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	07 Nov 2015 05:36AM UTC	Travis Job 7814.1
4	7814.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	07 Nov 2015 05:42AM UTC	Travis Job 7814.4
5	7814.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	07 Nov 2015 05:35AM UTC	Travis Job 7814.5
6	7814.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	07 Nov 2015 05:42AM UTC	Travis Job 7814.6
7	7814.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	07 Nov 2015 05:41AM UTC	Travis Job 7814.7
8	7814.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	07 Nov 2015 05:43AM UTC	Travis Job 7814.8
9	7814.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	07 Nov 2015 05:41AM UTC	Travis Job 7814.9
10	7814.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	07 Nov 2015 05:48AM UTC	Travis Job 7814.10

Source Files on build 7814

Detailed source file information is not available for this build.

pantsbuild / pants / 7814
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7814

pantsbuild / pants / 7814 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7814

pantsbuild / pants / 7814
0%
main: 93%

README BADGES
x