pantsbuild / pants / 7185
0%
main: 93%

LAST BUILD BRANCH: shell-completion-fs
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7185

push

travis-ci

Stu Hood 
Introduce instrument_classpath, and modify cobertura to use native class filtering

This change fixes cobertura integration by switching to a strategy that clones and instruments compiled jars rather than depending on .class files. It moves us closer to breaking coverage out into tasks by introducing an instrument_classpath product, and removes some unnecessary complexity by leveraging cobertura's native class filtering logic. Finally, it adds an integration test that will hopefully help cobertura coverage be more reliably functional down the road.

I had intended to split this branch up more, but because of the move to jar strategies as the default, cobertura integration was completely broken and I felt it was better to do a slightly longer branch but have things in a working state.

Subsequent branches will simplify the cobertura reporting (specifically the source file linking), deprecate emma integration, and completely refactor coverage into seperate tasks.

Testing Done:
Manual tests:
```bash
./pants clean-all test testprojects/tests/java/org/pantsbuild/testproject/unicode:: --test-junit-coverage-processor=cobertura --test-junit-coverage
open .pants.d/test/junit/coverage/xml/coverage.xml
```
New integration test:
```bash
./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration
```
Tests for cobertura class filtering:

The following leads to a report with 100% coverage (i.e. default includes all classes in instrumentation):
```bash
./pants clean-all test testprojects/tests/java/org/pantsbuild/testproject/unicode:: --test-junit-coverage-processor=cobertura --test-junit-coverage
```
The following leads to an empty report, as the only class in the project under test is covered by the exclude:
```bash
./pants clean-all test testprojects/tests/java/org/pantsbuild/testproject/unicode:: --test-junit-coverage-processor=cobertura --test-junit-coverage --test-junit-coverage-cobertura-exclude-classes='.*cucumber.*'
```
The following leads to a report with 100% coverage, as the only class is covered by the specified inclusion:
```bash
./pants clean-all test testprojects/tests/java/org/pantsbuild/testproject/unicode:: --test-junit-coverage-processor=cobertura --test-junit-coverage --test-junit-coverage-cobertura-include-classes='.*cucumber.*'
```

Bugs closed: 2245

Reviewed at https://rbcommons.com/s/twitter/r/2893/
Jobs
ID Job ID Ran Files Coverage
1 7185.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7185.1
4 7185.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7185.4
5 7185.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7185.5
6 7185.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7185.6
7 7185.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7185.7
8 7185.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7185.8
9 7185.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7185.9
10 7185.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7185.10
Source Files on build 7185
Detailed source file information is not available for this build.