7181
0%
main: 93%

Ran 30 Sep 2015 10:10PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7181

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Ensure execution graph cancellation only happens once per job

Before, the execution graph wouldn't check to see if a job had already been canceled before canceling it. This meant that even if that job was a dependee of another canceled or failed job, it would still end up in the queue. The result is that the queue could grow to be very large with deep graphs, containing mostly duplicate cancelations.

This patch changes the cancellation handling so that the status table is checked for each dependee before canceling it. It also marks them as queued so that the status table knows that they are in progress.

Testing Done:
Wrote a regression test, made it pass. CI away on the PR.

Bugs closed: 2290

Reviewed at https://rbcommons.com/s/twitter/r/2910/

closes #2290
closes #2282

Run Details

Jobs

ID	Job ID	Ran
1	7181.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	30 Sep 2015 10:10PM UTC	Travis Job 7181.1
4	7181.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	30 Sep 2015 10:12PM UTC	Travis Job 7181.4
5	7181.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	30 Sep 2015 10:15PM UTC	Travis Job 7181.5
6	7181.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	30 Sep 2015 10:21PM UTC	Travis Job 7181.6
7	7181.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	30 Sep 2015 10:25PM UTC	Travis Job 7181.7
8	7181.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	30 Sep 2015 10:20PM UTC	Travis Job 7181.8
9	7181.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	30 Sep 2015 10:24PM UTC	Travis Job 7181.9
10	7181.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	30 Sep 2015 10:25PM UTC	Travis Job 7181.10

Source Files on build 7181

Detailed source file information is not available for this build.

pantsbuild / pants / 7181
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7181

pantsbuild / pants / 7181 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7181

pantsbuild / pants / 7181
0%
main: 93%

README BADGES
x