• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 5981
0%
main: 93%

Build:
Build:
LAST BUILD BRANCH: feat-remote-cachable-intermediate-jars
DEFAULT BRANCH: main
Ran 04 Aug 2015 08:25PM UTC
Jobs 10
Files 348
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5981

push

travis-ci

gmalmquist
Moved logic which validates jvm platform dependencies.

The logic which checked to make sure no targets depended on other
targets with newer jdks was previously in jvm_compile, which caused
it to be re-ran for every single type of jvm compilation. It also
failed fast and had no option to simply warn and continue, which
made it hard and frustrating to debug.

JvmPlatformValidate is a new task whose sole purpose is performing
this validation. It runs fairly early in the build lifecycle, which
prevents pants from doing too much work before erroring on a doomed
run.

It also allows the error message to be disabled, or demoted to a warning.

Also included is a jvm platform debugging resource which I developed
(along with the previous change) to help me sort out many
jvm platform dependency problems in square's internal java repo.

This is done in the JvmPlatformExplain console task, which performs
a more detailed analysis of the target level constraints imposed on
targets by their dependencies and dependees (a target cannot have a
higher -target than its dependees, or a lower -target than its
dependencies).

Testing Done:
Existing tests modified, additional unit tests added in
test_jvm_platform_analysis.py.

CI went green: https://travis-ci.org/pantsbuild/pants/builds/74087340
Again: https://travis-ci.org/pantsbuild/pants/builds/74116016
Again: https://travis-ci.org/pantsbuild/pants/builds/74124235

Bugs closed: 1913

Reviewed at https://rbcommons.com/s/twitter/r/2565/

170 of 170 new or added lines in 2 files covered. (100.0%)

15279 of 20854 relevant lines covered (73.27%)

1.38 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
100.0
src/python/pants/backend/jvm/tasks/jvm_platform_analysis.py
2
100.0
src/python/pants/backend/jvm/register.py

Coverage Regressions

Lines Coverage ∆ File
1
100.0
src/python/pants/backend/jvm/register.py
1
100.0
src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py
Jobs
ID Job ID Ran Files Coverage
1 5981.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 04 Aug 2015 08:27PM UTC 0
Travis Job 5981.1
2 5981.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 04 Aug 2015 08:27PM UTC 0
69.0
Travis Job 5981.2
3 5981.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 04 Aug 2015 08:27PM UTC 0
68.96
Travis Job 5981.3
4 5981.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 04 Aug 2015 08:25PM UTC 0
Travis Job 5981.4
5 5981.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 04 Aug 2015 08:26PM UTC 0
Travis Job 5981.5
6 5981.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 04 Aug 2015 08:31PM UTC 0
Travis Job 5981.6
7 5981.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 04 Aug 2015 08:33PM UTC 0
Travis Job 5981.7
8 5981.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 04 Aug 2015 08:34PM UTC 0
Travis Job 5981.8
9 5981.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 04 Aug 2015 08:32PM UTC 0
Travis Job 5981.9
10 5981.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 04 Aug 2015 08:34PM UTC 0
Travis Job 5981.10
Source Files on build 5981
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #5981
  • b4581cfb on github
  • Prev Build on master (#5965)
  • Next Build on master (#5982)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc