pantsbuild / pants / 5965

0%

push

travis-ci

Fixup PythonTask chroot caching.

Previously there were a few issues that could lead to over-invalidation,
but most importantly, there was an issue leading to under-invalidation.

Fixup chroot target fingerprinting to be transitive, previously just the
top-level targets were fingerprinted.  This fixes under-invalidation
based on changes to python chroot transitive target dependency edits.

Also fixup unstable portions of the fingerprint with a few TODOs added
to do these more cleanly.

Add a PythonTaskTest that exercises these cases as well as the unchanged
chroot case.

Testing Done:
Manually tested pants from this branch against the repro case Paul set
up here: https://github.com/pgroudas/issues-1914
Without the fix his repro works - aka a revert fails to invalidate the
chroot cache.  With the fixed pants, reverts do force a new chroot to be
cached and used as expected.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/73984184

Bugs closed: 1914, 1916

Reviewed at https://rbcommons.com/s/twitter/r/2567/

10 of 10 new or added lines in 2 files covered. (100.0%)

15135 of 20706 relevant lines covered (73.09%)

1.38 hits per line