pantsbuild / pants / 5895
0%
main: 93%

LAST BUILD BRANCH: add/port-target-adaptor-and-source-block
DEFAULT BRANCH: main
Ran
Jobs 10
Files 343
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5895

push

travis-ci

John Sirois 
Fix straggler usage of legacy psutil form

- Fix straggler usage of legacy psutil property form in pidlock.py.
- Add a simple test case to exercise the psutil dependency to catch this in CI in the future.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/73467865

with the new test, pre-fix:

[illuminati pants (kwlzn/psutil_fixup)]$ PANTS_DEV=1 ./pants test tests/python/pants_test/process::
...
15:36:02 00:00     [pytest]
15:36:02 00:00       [run]
                     ============== test session starts ===============
                     platform darwin -- Python 2.7.6 -- py-1.4.30 -- pytest-2.6.4
                     plugins: timeout, cov
                     collected 9 items

                     tests/python/pants_test/process/test_pidlock.py F
                     tests/python/pants_test/process/test_xargs.py ........

                     ==================== FAILURES ====================
                      TestOwnerPrintingPIDLockFile.test_cmdline_for_pid

                     self = <pants_test.process.test_pidlock.TestOwnerPrintingPIDLockFile testMethod=test_cmdline_for_pid>

                         def test_cmdline_for_pid(self):
                     >     self.assertIsInstance(self.obj.cmdline_for_pid(os.getpid()))

                     tests/python/pants_test/process/test_pidlock.py:19:
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

                     pid = 82357

                         @staticmethod
                         def cmdline_for_pid(pid):
                           try:
                             process = psutil.Process(pid)
                     >       return ' '.join(process.cmdline)
                     E       TypeError

                     src/python/pants/process/pidlock.py:38: TypeError
                     ======= 1 failed, 8 passed in 0.05 seconds =======
...
FAILURE

and with the fix:

[illuminati pants (kwlzn/psutil_fixup)]$ PANTS_DEV=1 ./pants test tests/python/pants_test/process::
...
15:38:41 00:00     [pytest]
15:38:41 00:00       [run]
                     ============== test session starts ===============
                     platform darwin -- Python 2.7.6 -- py-1.4.30 -- pytest-2.6.4
                     plugins: timeout, cov
                     collected 9 items

                     tests/python/pants_test/process/test_pidlock.py .
                     tests/python/pants_test/process/test_xargs.py ........

                     ============ 9 passed in 0.04 seconds ============
...
               SUCCESS

Bugs closed: 1889

Reviewed at https://rbcommons.com/s/twitter/r/2546/

15041 of 20481 relevant lines covered (73.44%)

1.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5895.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 5895.1
2 5895.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
69.17
 Travis Job 5895.2
3 5895.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
68.86
 Travis Job 5895.3
4 5895.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 5895.4
5 5895.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 5895.5
6 5895.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 5895.6
7 5895.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 5895.7
8 5895.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 5895.8
9 5895.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 5895.9
10 5895.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 5895.10
Source Files on build 5895
Detailed source file information is not available for this build.